renderToPipeableStream: Expose errors through onError, no longer emit un-catchable error event on internal stream#405
Merged
JoviDeCroock merged 1 commit intopreactjs:mainfrom Jan 12, 2025
Conversation
… un-catchable error event on internal stream
🦋 Changeset detectedLatest commit: 310e1bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Jan 12, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #404
Changes error and abort handling in
renderToPipeableStreamso the stream no longer emits an uncatchable error event. Instead errors are passed tooptions.onErrorif provided. If there is no error callback it's rethrown, though maybe that's not ideal since it happens in the async chain, so can't really be caught either. Alternatively this could justconsole.error, so it doesn't get silently swallowed entirely?Also added an optional
reasonargument forstream.abort(), defaulting tonew Error(The render was aborted by the server without a reason.)inspired by React. Previously this was justnew Error('aborted'), though this was never exposed to consumers.Abort still destroys the stream, and also calls the
onErrorcallback (if defined) with the reason